Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdG0QRX (ORCPT ); Thu, 27 Jul 2017 12:17:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52026 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbdG0QRV (ORCPT ); Thu, 27 Jul 2017 12:17:21 -0400 Date: Thu, 27 Jul 2017 17:17:07 +0100 From: Mark Brown To: Tony Lindgren Cc: Frank Rowand , Grant Likely , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Takashi Iwai , Kuninori Morimoto , alsa-devel@alsa-project.org Message-ID: <20170727161707.uc36lxpg5x2bxajp@sirena.org.uk> References: <20170727094405.19778-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bpwpucmuuosseaxz" Content-Disposition: inline In-Reply-To: <20170727094405.19778-1-tony@atomide.com> X-Cookie: Licensed and bonded. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] device property: Fix usecount for of_graph_get_port_parent() X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 32 --bpwpucmuuosseaxz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 27, 2017 at 02:44:05AM -0700, Tony Lindgren wrote: > Fix inconsistent use of of_graph_get_port_parent() where > asoc_simple_card_parse_graph_dai() does of_node_get() before > calling it while other callers do not. We can fix this by > not trashing the node passed to of_graph_get_port_parent(). This looks like it gives a much less surprising API so hopefully helps avoid issues in callers: Reviewed-by: Mark Brown --bpwpucmuuosseaxz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAll6EgIACgkQJNaLcl1U h9B+OQf+N+0ajW5ZH/YBmCCSI/SUncBjj4w16WX6pS1o6C17X3UdY2ZSVQBUOM7j dwS22opewhLX2Pfbr6zEIMeanLSDq5pec2amVPTLKmTc1nOhiqODL46D+e65ZANI Tv/ZGi6SCVnHn6yh11/eOh2AQfiC6bg0SuP9Nueb4XF2/+tKpe7DZkmc65dobMcR p8tLJgXcHcpTjdrybIO8P3UomsuoDasI7NAid1kCyaan2zo6uLtjxFPv5xZfNs1k 6hC4znKV+jYaHyrg021vgi6tMM81RCu/4DhEBPXJvE0HIRVMIsbifHz1Cn79SiXJ LpQlDqMjz8N/Z37U+bg8U5Qk/gpthQ== =KMaW -----END PGP SIGNATURE----- --bpwpucmuuosseaxz--