Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbdG0Qyn (ORCPT ); Thu, 27 Jul 2017 12:54:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:60630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbdG0Qyk (ORCPT ); Thu, 27 Jul 2017 12:54:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E182022B4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 27 Jul 2017 13:54:34 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Jiri Olsa Subject: Re: [PATCH v4 2/9] perf annotate: Initialize proper width for first column Message-ID: <20170727165434.GC16224@kernel.org> References: <1501172156-6673-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501172156-6673-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 38 Em Fri, Jul 28, 2017 at 01:15:56AM +0900, Taeung Song escreveu: > When using --show-total-period or not, > set the width value for first column. > > Suggested-by: Arnaldo Carvalho de Melo > Cc: Namhyung Kim > Cc: Jiri Olsa > Signed-off-by: Taeung Song > --- > tools/perf/util/annotate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 5963764..5125c2b 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -1165,7 +1165,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st > } else if (max_lines && printed >= max_lines) > return 1; > else { > - int width = 8; > + int width = symbol_conf.show_total_period ? 12 : 8; > > if (queue) > return -1; > @@ -1806,7 +1806,7 @@ int symbol__annotate_printf(struct symbol *sym, struct map *map, > int printed = 2, queue_len = 0; > int more = 0; > u64 len; > - int width = 8; > + int width = symbol_conf.show_total_period ? 12 : 8; > int graph_dotted_len; Already at: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=ce9ee4a2de20062a97ad50ecc11ebda7e7618fd1 - Arnaldo