Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdG0Q45 (ORCPT ); Thu, 27 Jul 2017 12:56:57 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34618 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbdG0Q44 (ORCPT ); Thu, 27 Jul 2017 12:56:56 -0400 Date: Thu, 27 Jul 2017 17:56:13 +0100 From: Mark Brown To: Krzysztof Kozlowski Cc: Arvind Yadav , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20170727165613.uceqmidtgo52f3mx@sirena.org.uk> References: <20170726185729.28897-1-krzk@kernel.org> <20170726185729.28897-2-krzk@kernel.org> <49f6f3df-f7c9-cf7e-95ad-e3d6fdc78014@gmail.com> <20170727165113.dkqx2djk2b2rgbp4@kozik-lap> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xmacla7j4impttiy" Content-Disposition: inline In-Reply-To: <20170727165113.dkqx2djk2b2rgbp4@kozik-lap> X-Cookie: Licensed and bonded. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 35 --xmacla7j4impttiy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 27, 2017 at 06:51:13PM +0200, Krzysztof Kozlowski wrote: > On Thu, Jul 27, 2017 at 10:41:35AM +0530, Arvind Yadav wrote: > > On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: > > Now s3c2412_i2s.iis_cclk and s3c2412_i2s.iis_pclk are holding "iis" clock. > > Now no one handling "mpll" clock. If we will call s3c2412_i2s_remove. > > It's means. we are disabling "iis" clock twice. Which is not correct. > Right, what a obfuscated code is this... Thanks for pointing this out. > Also the s3c_i2sv2_probe() misses clk_prepare(). Yeah, I think the root cause here is that the code needs a cleanup so people can tell what's going on. --xmacla7j4impttiy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAll6GywACgkQJNaLcl1U h9Al2wf+KHBql1xY5QI8V6AJDm5Efcz4avJWn/WXPCf+ah2WiUeGUr8Yy0V5vFxQ dNClzPMueURCBc4WWqjUSzNJQaPEcolljWAuBmKW/Wd20XHi2e3fPenP/opbzoN5 WTRz5il7v4c+UrIC9b7v78wNO7ITWcB8d1gcWfsFuTTpGHGhbqODiTdWT3oDup2z FyJOnUKpf4DBA33LS04tilqVWyFMvplWovELn4bZCYcJId0zGPFqmYEZg+Twx+Yv ZlNtJFt+Nl9Euk8Ey53a801ytscgvZQ7dZpbE8KKn7+o8Akux3D2PWwkA6DFoWW5 rgvSWMIjnYLzQUTu2juzA3jeaYz7Eg== =9qy0 -----END PGP SIGNATURE----- --xmacla7j4impttiy--