Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdG0RyH (ORCPT ); Thu, 27 Jul 2017 13:54:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbdG0RyG (ORCPT ); Thu, 27 Jul 2017 13:54:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1F6E01F561 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=david@redhat.com Subject: Re: [PATCH] KVM: nVMX: do not pin the VMCS12 To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: dmatlack@google.com References: <1501163686-13648-1-git-send-email-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <625e249a-c60b-29e2-c6ed-f26f82f1d2dc@redhat.com> Date: Thu, 27 Jul 2017 19:54:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1501163686-13648-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 27 Jul 2017 17:54:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 478 Lines: 18 On 27.07.2017 15:54, Paolo Bonzini wrote: > Since the current implementation of VMCS12 does a memcpy in and out > of guest memory, we do not need current_vmcs12 and current_vmcs12_page > anymore. current_vmptr is enough to read and write the VMCS12. > > Signed-off-by: Paolo Bonzini This looks like the right thing to do! (and as mentioned, also properly marks the page as dirty) Reviewed-by: David Hildenbrand -- Thanks, David