Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdG0TM5 (ORCPT ); Thu, 27 Jul 2017 15:12:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57477 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbdG0TM4 (ORCPT ); Thu, 27 Jul 2017 15:12:56 -0400 Subject: Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask To: Nathan Fontenot , Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org References: <5c421712-fb38-3020-d3fc-b9bdea792cd3@linux.vnet.ibm.com> <47ac4fb9-a316-0125-7d4e-73cf602d891e@linux.vnet.ibm.com> From: Michael Bringmann Organization: IBM Linux Technology Center Date: Thu, 27 Jul 2017 14:12:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <47ac4fb9-a316-0125-7d4e-73cf602d891e@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17072719-8235-0000-0000-00000C02C8B9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007436; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00893762; UDB=6.00446855; IPR=6.00673922; BA=6.00005495; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016412; XFM=3.00000015; UTC=2017-07-27 19:12:54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072719-8236-0000-0000-00003CF46485 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-27_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707270299 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 33 >> >> /* yeap, return possible CPUs in @node that @attrs wants */ >> cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]); >> + >> + if (cpumask_empty(cpumask)) { >> + pr_warn_once("WARNING: workqueue cpumask: onl intersect > " > ^^^ > This message doesn't seem right, or I am missing something, "onl"? Shorthand for 'online' in long message. > > -Nathan > >> + "possible intersect\n"); >> + return false; >> + } >> + >> return !cpumask_equal(cpumask, attrs->cpumask); >> >> use_dfl: >> > -- Michael W. Bringmann Linux Technology Center IBM Corporation Tie-Line 363-5196 External: (512) 286-5196 Cell: (512) 466-0650 mwb@linux.vnet.ibm.com