Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751659AbdG0Vj0 (ORCPT ); Thu, 27 Jul 2017 17:39:26 -0400 Received: from elvis.franken.de ([193.175.24.41]:33439 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbdG0VjZ (ORCPT ); Thu, 27 Jul 2017 17:39:25 -0400 Date: Thu, 27 Jul 2017 23:39:15 +0200 From: Tom Bogendoerfer To: Laura Abbott Cc: isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces Message-ID: <20170727213915.GA4902@alpha.franken.de> References: <20170713092144.31751508094@solo.franken.de> <22ee6284-7b23-7664-d6cf-23687f09a3be@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22ee6284-7b23-7664-d6cf-23687f09a3be@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 24 On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: > This change causes boot failures for me on my APM Mustang system running > Fedora rawhide: > > [ 16.669089] Synchronous External Abort: synchronous external abort (0x9600000 > [ 16.669099] Internal error: : 96000010 [#1] SMP > [ 16.669103] Modules linked in: xgene_enet(+) at803x realtek mdio_xgene xgenes > [ 16.669127] CPU: 2 PID: 534 Comm: systemd-udevd Not tainted 4.13.0-0.rc1.git1 > [ 16.669128] Hardware name: AppliedMicro X-Gene Mustang Board/X-Gene Mustang 6 > [ 16.669131] task: ffff8003e6f8ce00 task.stack: ffff8003e4fd8000 > [ 16.669144] PC is at xgene_enet_wr_mac+0xa0/0x128 [xgene_enet] > [ 16.669152] LR is at xgene_enet_wr_mac+0x64/0x128 [xgene_enet] on the first glance I don't see anything clock related there. What firmware version is installed on your mustang board ? I saw ethernet related crashes with mustang boards because the device tree in firmware was too old for the xgene ethernet driver. Thoms. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]