Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660AbdG1ACB (ORCPT ); Thu, 27 Jul 2017 20:02:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52988 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbdG1AB7 (ORCPT ); Thu, 27 Jul 2017 20:01:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 09870609D1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 27 Jul 2017 17:01:58 -0700 From: Stephen Boyd To: Kiran Gunda Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Message-ID: <20170728000158.GW2146@codeaurora.org> References: <1500535910-28705-1-git-send-email-kgunda@codeaurora.org> <1500535910-28705-6-git-send-email-kgunda@codeaurora.org> <20170727234907.GT2146@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727234907.GT2146@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 22 On 07/27, Stephen Boyd wrote: > On 07/20, Kiran Gunda wrote: > > Allocate the correct memory size (max_pmic_peripherals) for the > > mapping_table that holds the apid to ppid mapping. Also use a local > > variable for mapping_table for better alignment of the code. > > > > Signed-off-by: Kiran Gunda > > This needs a > > Fixes: 987a9f128b8a ("spmi: pmic-arb: Support more than 128 peripherals") > > right? > Otherwise it has my Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project