Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbdG1BSI (ORCPT ); Thu, 27 Jul 2017 21:18:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50030 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbdG1BSG (ORCPT ); Thu, 27 Jul 2017 21:18:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BB981609FB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 27 Jul 2017 18:18:05 -0700 From: Stephen Boyd To: Kiran Gunda Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Message-ID: <20170728011805.GX2146@codeaurora.org> References: <1500535910-28705-1-git-send-email-kgunda@codeaurora.org> <1500535910-28705-4-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500535910-28705-4-git-send-email-kgunda@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 25 On 07/20, Kiran Gunda wrote: > Clean up the pmic_arb_find_apid() by using the local > variables to improve the code readability. > > Signed-off-by: Kiran Gunda > --- Reviewed-by: Stephen Boyd One nit below: > break; > > regval = readl_relaxed(pmic_arb->cnfg + > - SPMI_OWNERSHIP_TABLE_REG(apid)); > - pmic_arb->apid_data[apid].owner = > - SPMI_OWNERSHIP_PERIPH2OWNER(regval); > + SPMI_OWNERSHIP_TABLE_REG(apid)); This should be 7 spaces and not a tab? Originally looks like it was 6 spaces -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project