Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbdG1Efk (ORCPT ); Fri, 28 Jul 2017 00:35:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34940 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdG1Efi (ORCPT ); Fri, 28 Jul 2017 00:35:38 -0400 Date: Thu, 27 Jul 2017 21:35:33 -0700 From: Greg KH To: Amitoj Kaur Chawla Cc: david.kershner@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: visorchipset: constify attribute_group structure Message-ID: <20170728043533.GB27597@kroah.com> References: <20170727015132.GA10264@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727015132.GA10264@amitoj-Inspiron-3542> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 37 On Wed, Jul 26, 2017 at 09:51:32PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec hex filename > 24124 6216 448 30788 7844 > drivers/staging/unisys/visorbus/visorchipset.o > > File size after: > text data bss dec hex filename > 24220 6120 448 30788 7844 > drivers/staging/unisys/visorbus/visorchipset.o > > This change was made with the help of Coccinelle. > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/staging/unisys/visorbus/visorchipset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c > index 2215056..798a92e 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -1146,7 +1146,7 @@ static struct attribute *visorchipset_parahotplug_attrs[] = { > NULL > }; > > -static struct attribute_group visorchipset_parahotplug_group = { > +static const struct attribute_group visorchipset_parahotplug_group = { > .name = "parahotplug", > .attrs = visorchipset_parahotplug_attrs > }; Someone else sent this change right before you did :(