Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbdG1Fdf (ORCPT ); Fri, 28 Jul 2017 01:33:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60956 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdG1Fdd (ORCPT ); Fri, 28 Jul 2017 01:33:33 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 28 Jul 2017 11:03:32 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: gregkh@linuxfoundation.org, Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function In-Reply-To: <20170728011805.GX2146@codeaurora.org> References: <1500535910-28705-1-git-send-email-kgunda@codeaurora.org> <1500535910-28705-4-git-send-email-kgunda@codeaurora.org> <20170728011805.GX2146@codeaurora.org> Message-ID: <60e3f73bc6661166af32eca4a8bd0743@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 23 On 2017-07-28 06:48, Stephen Boyd wrote: > On 07/20, Kiran Gunda wrote: >> Clean up the pmic_arb_find_apid() by using the local >> variables to improve the code readability. >> >> Signed-off-by: Kiran Gunda >> --- > > Reviewed-by: Stephen Boyd > > One nit below: > >> break; >> >> regval = readl_relaxed(pmic_arb->cnfg + >> - SPMI_OWNERSHIP_TABLE_REG(apid)); >> - pmic_arb->apid_data[apid].owner = >> - SPMI_OWNERSHIP_PERIPH2OWNER(regval); >> + SPMI_OWNERSHIP_TABLE_REG(apid)); > > This should be 7 spaces and not a tab? Originally looks like it > was 6 spaces Will fix it and send the next patch.