Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbdG1Foy (ORCPT ); Fri, 28 Jul 2017 01:44:54 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36763 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbdG1Fox (ORCPT ); Fri, 28 Jul 2017 01:44:53 -0400 Date: Fri, 28 Jul 2017 07:44:40 +0200 From: Krzysztof Kozlowski To: Arvind Yadav Cc: Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Message-ID: <20170728054440.GA2650@kozik-book> References: <20170727171338.13300-1-krzk@kernel.org> <20170727171338.13300-3-krzk@kernel.org> <36fcdba7-309b-68b0-f3e4-f2de89526af7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <36fcdba7-309b-68b0-f3e4-f2de89526af7@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 35 On Fri, Jul 28, 2017 at 10:11:48AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: > >The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't > >probably fatal, because for SoC clocks this is usually no-op, but for > >correctness this clock should be prepared. > > > >Signed-off-by: Krzysztof Kozlowski > > > >--- > > > >Changes since v1: > >1. New patch > >--- > > sound/soc/samsung/s3c-i2s-v2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c > >index 9b28046eea8e..3894bda06ebb 100644 > >--- a/sound/soc/samsung/s3c-i2s-v2.c > >+++ b/sound/soc/samsung/s3c-i2s-v2.c > >@@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai, > > return -ENOENT; > > } > >- clk_enable(i2s->iis_pclk); > >+ clk_prepare_enable(i2s->iis_pclk); > Please, handle are return value of clk_prepare_enble. Which is a different issue, different bug. We can fix it but it should be not mixed with this fix here. Best regards, Krzysztof