Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbdG1JuX (ORCPT ); Fri, 28 Jul 2017 05:50:23 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:52624 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbdG1JuT (ORCPT ); Fri, 28 Jul 2017 05:50:19 -0400 MIME-Version: 1.0 In-Reply-To: <20170728092818.23419-4-clabbe.montjoie@gmail.com> References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> <20170728092818.23419-4-clabbe.montjoie@gmail.com> From: Chen-Yu Tsai Date: Fri, 28 Jul 2017 17:49:55 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible To: Corentin Labbe Cc: Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Russell King , Giuseppe Cavallaro , alexandre.torgue@st.com, Icenowy Zheng , netdev , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 34 On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe wrote: > The current way to find if the phy is internal is to compare DT phy-mode > and emac_variant/internal_phy. > But it will negate a possible future SoC where an external PHY use the > same phy mode than the internal one. > > This patch adds a new way to find if the PHY is internal, via its > compatible. > > Since the phy_mode of the internal PHY does need to be know, the > variant internal_phy member is converted to a boolean. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index fffd6d5fc907..04f7ddd802b0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -48,7 +48,7 @@ > */ > struct emac_variant { > u32 default_syscon_value; > - int internal_phy; > + bool internal_phy; Nit: please add a verb to the name, like "has_internal_phy", or even "soc_has_internal_phy". This makes it clear what this property represents. ChenYu