Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751996AbdG1Jyp (ORCPT ); Fri, 28 Jul 2017 05:54:45 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38033 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdG1Jyl (ORCPT ); Fri, 28 Jul 2017 05:54:41 -0400 Date: Fri, 28 Jul 2017 11:54:27 +0200 From: Corentin Labbe To: Chen-Yu Tsai Cc: Rob Herring , Mark Rutland , Maxime Ripard , Russell King , Giuseppe Cavallaro , alexandre.torgue@st.com, Icenowy Zheng , netdev , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH 3/3] net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Message-ID: <20170728095427.GA31579@Red> References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> <20170728092818.23419-4-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 39 On Fri, Jul 28, 2017 at 05:49:55PM +0800, Chen-Yu Tsai wrote: > On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe > wrote: > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > This patch adds a new way to find if the PHY is internal, via its > > compatible. > > > > Since the phy_mode of the internal PHY does need to be know, the > > variant internal_phy member is converted to a boolean. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > > index fffd6d5fc907..04f7ddd802b0 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > > @@ -48,7 +48,7 @@ > > */ > > struct emac_variant { > > u32 default_syscon_value; > > - int internal_phy; > > + bool internal_phy; > > Nit: please add a verb to the name, like "has_internal_phy", > or even "soc_has_internal_phy". This makes it clear what this > property represents. > > ChenYu I will use soc_has_internal_phy Thanks