Date: Fri, 28 Jul 2017 11:55:25 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, keescook@chromium.org, tglx@linutronix.de,
        hpa@zytor.com, izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com,
        thgarnie@google.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be
 randomized in mirror regions
Message-ID: <20170728095525.y4tuv6aavzfs4ekb@gmail.com>
References: <1500542189-15779-1-git-send-email-bhe@redhat.com>
 <20170721103757.hc74czr3mfunrv6c@gmail.com>
 <20170721131956.GK2344@x1>
 <20170724133410.GC11076@codeblueprint.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170724133410.GC11076@codeblueprint.co.uk>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 903
Lines: 28


* Matt Fleming <matt@codeblueprint.co.uk> wrote:

> On Fri, 21 Jul, at 09:19:56PM, Baoquan He wrote:
> >
> > There are places where the efi map is getting and used like this. E.g
> > in efi_high_alloc() of drivers/firmware/efi/libstub/efi-stub-helper.c.
> > EFI developers worry the size of efi_memory_desc_t could not be the same
> > as e->efi_memdesc_size?
> > 
> > Hi Matt,
> > 
> > Could you help have a look at this?
> 
> You're exactly right. The code guards against the size of the
> efi_memory_desc_t struct changing. The UEFI spec says to traverse the
> memory map this way.

This is not obvious and looks pretty ugly as well, and open coded in several 
places.

At minimum we should have an efi_memdesc_ptr(efi, i) wrapper inline (or so) that 
gives us the entry pointer, plus a comment that points out that ->memdesc_size 
might not be equal to sizeof(efi_memory_memdesc_t).

Thanks,

	Ingo