Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdG1L1E (ORCPT ); Fri, 28 Jul 2017 07:27:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbdG1L1D (ORCPT ); Fri, 28 Jul 2017 07:27:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E43A1CFA88 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com Date: Fri, 28 Jul 2017 19:26:59 +0800 From: Baoquan He To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled Message-ID: <20170728112659.GT24304@x1> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-11-git-send-email-bhe@redhat.com> <20170727155550.GO3610@suse.de> <20170728090619.GM24304@x1> <20170728111439.GB3431@suse.de> <20170728111553.GR24304@x1> <20170728111809.GC3431@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170728111809.GC3431@suse.de> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 28 Jul 2017 11:27:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 12 On 07/28/17 at 01:18pm, Joerg Roedel wrote: > On Fri, Jul 28, 2017 at 07:15:53PM +0800, Baoquan He wrote: > > On 07/28/17 at 01:14pm, Joerg Roedel wrote: > > > Yes, exactly, the first device table also needs to be allocated with > > > GFP_DMA32 so that it ends up below 4GB. > > > > Got it, will do. Thanks! > > Oh, and you also need to check in the kdump kernel whether the old > device-table is really below 4GB and abort the copy otherwise. Ah, indeed. Will change it. Thanks.