Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbdG1MhX (ORCPT ); Fri, 28 Jul 2017 08:37:23 -0400 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]:60913 "EHLO lb1-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbdG1MhP (ORCPT ); Fri, 28 Jul 2017 08:37:15 -0400 Subject: Re: [PATCH v3 0/2] media: Add Amlogic Meson AO CEC Controller support From: Hans Verkuil To: Neil Armstrong , mchehab@kernel.org, hans.verkuil@cisco.com Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1501168830-5308-1-git-send-email-narmstrong@baylibre.com> Message-ID: <36cab0eb-0986-58d6-9cec-9bf4ab099495@xs4all.nl> Date: Fri, 28 Jul 2017 14:37:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKvzvU9xAGRDWlriFKbpqSUqAEkdwFnp+oTX2tSxotNTq6HBGFqA9XlDJMZ2GwMyHmsROalYNJkSSSzjBvHbwzKcqnbHaCo7d8aN61K19W6lYVtLNThi NG3FZnfU6oCTROcBC06sd5D0moK6lCD5XpDs5PPByIMUGA4QZQ8SM9GCFOrqxgFEIafRiwRXPVfB8PDMyBJszyWN331gy9d/b5zMyxvP/w8Czn2g/glYfEho YHELMUNYoUHD4CfW06fJqb8sRYuAL59kdobLXF45ooil3nrzDZo9XsNBxdApkZTb3jEDR5TpA8VObNttK8OgQ5fWhXP1KEv+5QhfPU9IMv61b9xylKvY64Zg N+endQsSZriLgTnU0XbiGhDM8BHGArHG3QHWzmxcsRa2AOlKg5c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 62 On 07/28/2017 02:35 PM, Hans Verkuil wrote: > Hi Neil, > > On 07/27/2017 05:20 PM, Neil Armstrong wrote: >> The Amlogic SoC embeds a standalone CEC controller, this patch adds a driver >> for such controller. >> The controller does not need HPD to be active, and could support up to max >> 5 logical addresses, but only 1 is handled since the Suspend firmware can >> make use of this unique logical address to wake up the device. >> >> The Suspend firmware configuration will be added in an other patchset. > > Note that to get the right module dependencies you will also need to add > this line: > > select CEC_CORE if CEC_NOTIFIER > > to DRM_MESON_DW_HDMI in drivers/gpu/drm/meson/Kconfig. > > This ensures that if DRM_MESON_DW_HDMI is 'y' but VIDEO_MESON_AO_CEC is 'm' > the CEC_CORE config is set to 'y'. > > Obviously this is a patch for dri-devel. I was too quick sending this: I expect this line to appear in DRM_DW_HDMI, not DRM_MESON_DW_HDMI. Sorry about the noise. Hans > > Regards, > > Hans > >> >> Changes since v2 at [2] : >> - change meson_ao_cec_read/write prototype to simplify error handling >> >> Changes since v1 at [1] : >> - add timeout to wait busy, with error return >> - handle busy error in all read/write operations >> - add CEC_CAP_PASSTHROUGH >> - add bindings ack >> >> [1] https://lkml.kernel.org/r/1499336870-24118-1-git-send-email-narmstrong@baylibre.com >> [2] https://lkml.kernel.org/r/1499673696-21372-1-git-send-email-narmstrong@baylibre.com >> >> Neil Armstrong (2): >> platform: Add Amlogic Meson AO CEC Controller driver >> dt-bindings: media: Add Amlogic Meson AO-CEC bindings >> >> .../devicetree/bindings/media/meson-ao-cec.txt | 28 + >> drivers/media/platform/Kconfig | 11 + >> drivers/media/platform/Makefile | 2 + >> drivers/media/platform/meson/Makefile | 1 + >> drivers/media/platform/meson/ao-cec.c | 744 +++++++++++++++++++++ >> 5 files changed, 786 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/meson-ao-cec.txt >> create mode 100644 drivers/media/platform/meson/Makefile >> create mode 100644 drivers/media/platform/meson/ao-cec.c >> >