Subject: Re: Suspend-resume failure on Intel Eagle Lake Core2Duo
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Martin Peres <martin.peres@linux.intel.com>, jeffy.chen@rock-chips.com,
        linux-kernel@vger.kernel.org
References: <4d6b511a-61d5-3c5e-a406-9f71d83670b6@linux.intel.com>
 <alpine.DEB.2.20.1707241711020.1988@nanos>
 <864ff133-815c-0c7f-5e36-fdcc32d0261d@linux.intel.com>
 <alpine.DEB.2.20.1707241833270.1988@nanos>
 <2ecc8ffd-e041-2d53-6f33-e91b3ec701eb@linux.intel.com>
 <a585961a-3e07-b086-577a-729ad20d9935@intel.com>
 <67de95b4-a869-d897-e76c-17c974fb21a6@linux.intel.com>
 <alpine.DEB.2.20.1707261625010.2186@nanos>
 <862ba91e-9185-89a8-da81-63bb42ea565d@intel.com>
 <alpine.DEB.2.20.1707270939290.3109@nanos>
 <ddc71535-02de-5b42-934f-70bc5ad43bb7@intel.com>
 <alpine.DEB.2.20.1707272138080.2368@nanos>
 <alpine.DEB.2.20.1707272209130.2368@nanos>
 <alpine.DEB.2.20.1707272306310.2368@nanos>
 <7287f845-1012-51af-e696-99d26bcb9b7f@intel.com>
 <alpine.DEB.2.20.1707281439120.1986@nanos>
 <alpine.DEB.2.20.1707281514000.1986@nanos>
From: Tomi Sarvela <tomi.p.sarvela@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Message-ID: <f7f52efa-f45c-7e9e-e407-a72c13a55089@intel.com>
Date: Fri, 28 Jul 2017 16:25:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1707281514000.1986@nanos>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3575
Lines: 99

On 28/07/17 16:15, Thomas Gleixner wrote:
> On Fri, 28 Jul 2017, Thomas Gleixner wrote:
>> On Fri, 28 Jul 2017, Tomi Sarvela wrote:
>>> On 28/07/17 00:08, Thomas Gleixner wrote:
>>> The patch didn't apply cleanly: can you tell exact commit or tag it has been
>>> created against?
>>
>> Linus head
>>
>>> I tried to hand-wrangle the changes in, but then I got compilation
>>> errors:
>>
>> Sorry, forgot to refresh the patch. Working version below.
>>
>>> Also, the usage of /sys/power/pm_test was not intuitive to me. Can you explain
>>> which kind of combinations do you want to test?

This tested against just fetched 4.13.0-rc2 origin/master.

>> # echo freezer >/sys/power/pm_test
>> # echo mem >/sys/power/state

Works.

>> # echo devices >/sys/power/pm_test
>> # echo mem >/sys/power/state

Works.

>> # echo platform >/sys/power/pm_test
>> # echo mem >/sys/power/state

Works.

>> To reset the test stuff do:
>> # echo none >/sys/power/pm_test

>> Please try that before applying the debug patch.

Going with the suspend test, and it still leaves host dead.

root@elk:/opt/igt# ./tests/gem_exec_suspend --r basic-S3
IGT-Version: 1.19-gf1454751 (x86_64) (Linux: 4.13.0-rc2+ x86_64)
rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Jul 28 13:21:27 2017

> Another question. Is the machine completely dead or not?

Completely dead. Powerled is on, so host isn't shut down. Serial or 
network if don't give any signs of life.

Patch applies cleanly but still getting the same error:
   LD      vmlinux.o
kernel/irq/handle.o:(.bss+0x0): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:(.bss+0x0): first defined here
kernel/irq/manage.o:(.bss+0x8): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/spurious.o:(.bss+0x0): multiple definition of 
`irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/resend.o:(.bss+0x0): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/chip.o:(.bss+0x0): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/dummychip.o:(.bss+0x0): multiple definition of 
`irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/devres.o:(.bss+0x0): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/autoprobe.o:(.bss+0x0): multiple definition of 
`irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/proc.o:(.bss+0x4): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/migration.o:(.bss+0x0): multiple definition of 
`irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/cpuhotplug.o:(.bss+0x0): multiple definition of 
`irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here
kernel/irq/pm.o:(.bss+0x0): multiple definition of `irq_suspend_resume'
kernel/irq/irqdesc.o:/home/testrunner/kernel/kernel/irq/irqdesc.c:270: 
first defined here


Best regards,

Tomi
-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo