Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdG1Nrr (ORCPT ); Fri, 28 Jul 2017 09:47:47 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43700 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdG1Nrp (ORCPT ); Fri, 28 Jul 2017 09:47:45 -0400 Date: Fri, 28 Jul 2017 15:47:36 +0200 From: Andrew Lunn To: Chen-Yu Tsai Cc: Corentin Labbe , Mark Rutland , devicetree , alexandre.torgue@st.com, netdev , linux-sunxi , Russell King , linux-kernel , Rob Herring , Giuseppe Cavallaro , Maxime Ripard , linux-arm-kernel , Icenowy Zheng Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Message-ID: <20170728134736.GC32230@lunn.ch> References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 22 On Fri, Jul 28, 2017 at 05:53:40PM +0800, Chen-Yu Tsai wrote: > On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe > wrote: > > Hello > > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > This patchs series adds a new way to find if the PHY is internal, via its > > compatible. > > You've already joined in on the discussion for the patch "net: stmmac: > dwmac-rk: Add internal phy support". It is pretty much the same issue. > Please wait for it to come to a proper conclusion. At least then we can > agree on something so different platforms with the same problem don't > have diverging solutions. Yes, this is important. Andrew