Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752045AbdG1OH7 (ORCPT ); Fri, 28 Jul 2017 10:07:59 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:32922 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbdG1OH5 (ORCPT ); Fri, 28 Jul 2017 10:07:57 -0400 Date: Fri, 28 Jul 2017 07:07:51 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <20170728131826.180483-1-arnd@arndb.de> References: <20170728131826.180483-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] HID: wacom: add USB_HID dependency To: Arnd Bergmann , Jiri Kosina CC: Jason Gerecke , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Jason Gerecke Message-ID: <6C9C978F-447D-42A5-9245-894577F2944D@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6SE85hr013476 Content-Length: 1228 Lines: 33 On July 28, 2017 6:18:00 AM PDT, Arnd Bergmann wrote: >The driver has gained a compile-time dependency that we should >express in Kconfig to avoid this link error: > Would conditional compilation be an acceptable alternative to adding a dependency? The USB_HID code is only used to check if the driver is working with a USB device. With USB_HID disabled, there's no need for the check so there's no need for the dependency. >drivers/hid/wacom_sys.o: In function `wacom_parse_and_register': >wacom_sys.c:(.text+0x2eec): undefined reference to `usb_hid_driver' > >Fixes: 09dc28acaec7 ("HID: wacom: Improve generic name generation") >Signed-off-by: Arnd Bergmann >--- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >index 3cd60f460b61..0a3117cc29e7 100644 >--- a/drivers/hid/Kconfig >+++ b/drivers/hid/Kconfig >@@ -924,7 +924,7 @@ config HID_UDRAW_PS3 > > config HID_WACOM > tristate "Wacom Intuos/Graphire tablet support (USB)" >- depends on HID >+ depends on USB_HID > select POWER_SUPPLY > select NEW_LEDS > select LEDS_CLASS -- Sent from my Android device with K-9 Mail. Please excuse my brevity.