Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752117AbdG1Oog (ORCPT ); Fri, 28 Jul 2017 10:44:36 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33041 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdG1Ood (ORCPT ); Fri, 28 Jul 2017 10:44:33 -0400 Date: Fri, 28 Jul 2017 16:44:24 +0200 From: Corentin Labbe To: Andrew Lunn Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, peppe.cavallaro@st.com, alexandre.torgue@st.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode Message-ID: <20170728144424.GB7221@Red> References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> <20170728135544.GD32230@lunn.ch> <20170728142508.GA7221@Red> <20170728143600.GB2132@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170728143600.GB2132@lunn.ch> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 23 On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > > > I've probably asked this before: Does the internal PHY use a different > > > PHY ID in registers 2 and 3? > > > > > > > yes > > > > reg2: 0x0044 > > reg3: 0X1500 Copy/paste error, its 1400 > > So this is not about loading the correct PHY driver. You can already > do this based on the PHY IDs... > > This is about selecting which PHY to use. Internal or External? > > Andrew It is too late when we know the PHY ID. We need to set a syscon for choosing external/internal PHY. So we can rely only on DT.