Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbdG1PRA (ORCPT ); Fri, 28 Jul 2017 11:17:00 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:55804 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbdG1PQ7 (ORCPT ); Fri, 28 Jul 2017 11:16:59 -0400 Date: Fri, 28 Jul 2017 17:16:56 +0200 (CEST) From: Marcus Wolf To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Dan Carpenter Message-ID: <643844683.9182.1501255016794@ox.hosteurope.de> In-Reply-To: <20170728142636.e6vzzwhc53mv6qpt@mwanda> References: <20170728132339.332897-1-arnd@arndb.de> <569585967.8859.1501251665326@ox.hosteurope.de> <20170728142636.e6vzzwhc53mv6qpt@mwanda> Subject: Send a large patch right now or is it better to do it later? MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev29 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1501255019;42085240; X-HE-SMSGID: 1db70a-0002QQ-T2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 26 Hi Greg, according to the proposals of Walter Harms, I revised the rf69.c: I replaced some macros with inline functions and removed some obsolete ifdefs. According to walter this will improve the resource situation. In addition the readybility is enhanced, since lines got shorter. It's a quite big change, that touched nearly every function in that file. I was testing the new code for a while now and did not observer a problem so far. But I don't have a kind of unit test, so my tests for sure didn't cover everything. Is it a good time, to submit such a change in these days, or is it prefrable to submit it later? In adition, I am a bit afraid of my current mailtool doing something unexpected... If you like, I can give it a try! Cheers, Marcus P.S. Can you process diffs fom SVN, too, or is it mandatory to create the diff with git?