Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbdG1PUk (ORCPT ); Fri, 28 Jul 2017 11:20:40 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43979 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdG1PUj (ORCPT ); Fri, 28 Jul 2017 11:20:39 -0400 Date: Fri, 28 Jul 2017 17:20:37 +0200 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Message-ID: <20170728152037.GF2132@lunn.ch> References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-3-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170728151157.28983-3-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 322 Lines: 11 On Fri, Jul 28, 2017 at 05:11:55PM +0200, Egil Hjelmeland wrote: > lan9303_mdio_write()/_read() must multiply register number by 4 to get > offset. > > Added some commments to the register definitions. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew