Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbdG1Pjx (ORCPT ); Fri, 28 Jul 2017 11:39:53 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45534 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbdG1Pjv (ORCPT ); Fri, 28 Jul 2017 11:39:51 -0400 From: Vivien Didelot To: Egil Hjelmeland , andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Cc: Egil Hjelmeland Subject: Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register In-Reply-To: <20170728151157.28983-3-privat@egil-hjelmeland.no> References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-3-privat@egil-hjelmeland.no> Date: Fri, 28 Jul 2017 11:37:03 -0400 Message-ID: <87lgn8lgio.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 320 Lines: 10 Egil Hjelmeland writes: > lan9303_mdio_write()/_read() must multiply register number by 4 to get > offset. > > Added some commments to the register definitions. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Vivien Didelot