Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbdG1PmN (ORCPT ); Fri, 28 Jul 2017 11:42:13 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45854 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdG1PmL (ORCPT ); Fri, 28 Jul 2017 11:42:11 -0400 From: Vivien Didelot To: Egil Hjelmeland , andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Cc: Egil Hjelmeland Subject: Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly In-Reply-To: <20170728151157.28983-5-privat@egil-hjelmeland.no> References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-5-privat@egil-hjelmeland.no> Date: Fri, 28 Jul 2017 11:39:22 -0400 Message-ID: <87fudglget.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 342 Lines: 16 Hi Egil, Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { > + .phy_read = lan9303_indirect_phy_read, > + .phy_write = lan9303_indirect_phy_write, > +}; > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? Thanks, Vivien