Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbdG1QR6 (ORCPT ); Fri, 28 Jul 2017 12:17:58 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:23676 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdG1QRz (ORCPT ); Fri, 28 Jul 2017 12:17:55 -0400 X-IronPort-AV: E=Sophos;i="5.40,425,1496073600"; d="scan'208";a="37057516" From: Bart Van Assche To: "dan.j.williams@intel.com" , "linux-nvdimm@lists.01.org" CC: "dm-devel@redhat.com" , "linux-kernel@vger.kernel.org" , "toshi.kani@hpe.com" , "linux-block@vger.kernel.org" , "hch@lst.de" , "snitzer@redhat.com" , "linux-fsdevel@vger.kernel.org" Subject: Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Thread-Topic: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Thread-Index: AQHSt68N9Qj1Xbxua02B9V2ggfYo66JqCoeA Date: Fri, 28 Jul 2017 16:17:07 +0000 Message-ID: <1501258623.2413.3.camel@wdc.com> References: <149245612770.10206.15496018295337908594.stgit@dwillia2-desk3.amr.corp.intel.com> <149245618859.10206.13182319600260215993.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <149245618859.10206.13182319600260215993.stgit@dwillia2-desk3.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;20:WyJXDM9dsdWujzOWz5vixAUc6uALupyB25ZAEY+kUWxLi2mxHIwFgDw+kLzBeRbn7cfp7s+gR9REJMSf5Dx9K/12Hr/h5Wy3GmdRHi1qrcEgNRNbxxhhaNWpdI8RbJI7VRFyB9qnmca27XNAKVCUmY7J0yoryHNuJmx6X00MdXY= x-ms-office365-filtering-correlation-id: 1570a701-8602-4145-b803-08d4d5d4179a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1533; x-ms-traffictypediagnostic: CY1PR0401MB1533: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1533; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39860400002)(39850400002)(39400400002)(39410400002)(39840400002)(24454002)(199003)(377424004)(189002)(2501003)(66066001)(6436002)(106356001)(53936002)(189998001)(72206003)(3660700001)(4326008)(2950100002)(86362001)(3846002)(102836003)(6116002)(3280700002)(2906002)(478600001)(36756003)(101416001)(6506006)(103116003)(68736007)(6246003)(54906002)(99286003)(25786009)(5660300001)(14454004)(81166006)(81156014)(6512007)(8676002)(305945005)(38730400002)(105586002)(8936002)(33646002)(50986999)(77096006)(54356999)(7736002)(2900100001)(76176999)(229853002)(6486002)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <45C5A08BBF091D4C8A2DA2234541D60E@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2017 16:17:07.0787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6SGI3On021253 Content-Length: 908 Lines: 27 On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote: > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index b7767da50c26..1de8372d9459 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -200,6 +200,7 @@ config BLK_DEV_DM_BUILTIN > config BLK_DEV_DM > tristate "Device mapper support" > select BLK_DEV_DM_BUILTIN > + select DAX > ---help--- > Device-mapper is a low level volume manager. It works by allowing > people to specify mappings for ranges of logical sectors. Various (replying to an e-mail of three months ago) Hello Dan, While building a v4.12 kernel I noticed that enabling device mapper support now unconditionally enables DAX. I think there are plenty of systems that use dm but do not need DAX. Have you considered to rework this such that instead of dm selecting DAX that DAX support is only enabled in dm if CONFIG_DAX is enabled? Thanks, Bart.