Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbdG1QYu (ORCPT ); Fri, 28 Jul 2017 12:24:50 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60902 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdG1QYt (ORCPT ); Fri, 28 Jul 2017 12:24:49 -0400 Subject: Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly To: Vivien Didelot , andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-5-privat@egil-hjelmeland.no> <87fudglget.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> From: Egil Hjelmeland Message-ID: <50d2d34c-c1a5-7f0a-90f1-44b1be1775b7@egil-hjelmeland.no> Date: Fri, 28 Jul 2017 18:24:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87fudglget.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 509 Lines: 23 Den 28. juli 2017 17:39, skrev Vivien Didelot: > Hi Egil, > > Egil Hjelmeland writes: > >> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { >> + .phy_read = lan9303_indirect_phy_read, >> + .phy_write = lan9303_indirect_phy_write, >> +}; >> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > > Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > > > Thanks, > > Vivien > I have no opinion. I just used the same variant as the other EXPORTS in the file. Egil