Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752478AbdG1Q0d (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Jul 2017 12:26:33 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:59507 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752442AbdG1Q0b (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Jul 2017 12:26:31 -0400
Date: Fri, 28 Jul 2017 18:26:15 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tomi Sarvela <tomi.p.sarvela@intel.com>
cc: Martin Peres <martin.peres@linux.intel.com>, jeffy.chen@rock-chips.com,
        linux-kernel@vger.kernel.org
Subject: Re: Suspend-resume failure on Intel Eagle Lake Core2Duo
In-Reply-To: <1d2c51f3-a655-2223-68a9-e6d700e7d8e1@intel.com>
Message-ID: <alpine.DEB.2.20.1707281734240.1828@nanos>
References: <4d6b511a-61d5-3c5e-a406-9f71d83670b6@linux.intel.com> <alpine.DEB.2.20.1707241833270.1988@nanos> <2ecc8ffd-e041-2d53-6f33-e91b3ec701eb@linux.intel.com> <a585961a-3e07-b086-577a-729ad20d9935@intel.com> <67de95b4-a869-d897-e76c-17c974fb21a6@linux.intel.com>
 <alpine.DEB.2.20.1707261625010.2186@nanos> <862ba91e-9185-89a8-da81-63bb42ea565d@intel.com> <alpine.DEB.2.20.1707270939290.3109@nanos> <ddc71535-02de-5b42-934f-70bc5ad43bb7@intel.com> <alpine.DEB.2.20.1707272138080.2368@nanos> <alpine.DEB.2.20.1707272209130.2368@nanos>
 <alpine.DEB.2.20.1707272306310.2368@nanos> <7287f845-1012-51af-e696-99d26bcb9b7f@intel.com> <alpine.DEB.2.20.1707281439120.1986@nanos> <alpine.DEB.2.20.1707281514000.1986@nanos> <f7f52efa-f45c-7e9e-e407-a72c13a55089@intel.com> <alpine.DEB.2.20.1707281609250.1986@nanos>
 <d7c5c87e-7ff4-6599-4f93-5ea4a9ae17b4@intel.com> <alpine.DEB.2.20.1707281649210.1828@nanos> <1d2c51f3-a655-2223-68a9-e6d700e7d8e1@intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1836
Lines: 51

On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> On 28/07/17 17:50, Thomas Gleixner wrote:
> > On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> > > On 28/07/17 17:13, Thomas Gleixner wrote:
> > > > On Fri, 28 Jul 2017, Tomi Sarvela wrote:
> > > > > On 28/07/17 16:15, Thomas Gleixner wrote:
> > > > > > Another question. Is the machine completely dead or not?
> > > > > 
> > > > > Completely dead. Powerled is on, so host isn't shut down.
> > > > 
> > > > So that means it does not even power the machine down. That's what I
> > > > expected least.
> > > > 
> > > > > Serial or network if don't give any signs of life.
> > > > 
> > > > > Patch applies cleanly but still getting the same error:
> > > > 
> > > > Sorry for the noise. I'm an idiot trying to do 10 things at once. This
> > > > time
> > > > it actually compiles and links.
> > > > 
> > > > If the machine does still not powerdown with this applied, then please
> > > > redo
> > > > the 'platform' test and grab the trace for that one.
> > > 
> > > This patch fixes the issue. Below is the dmesg from the testrun (sorry for
> > > the spam, we're primarily testing i915 issues).
> > 
> > Can you please retrieve the trace data from:
> > 
> > /sys/kernel/debug/tracing/trace
> > 
> > and provide that. The dmesg does not help much.
> 
> Right, here you go.

Thanks for providing the data. Just to be sure, that data was from a real
suspend, not the 'platform' test, right?

If so, that does not make any sense at all. The patch merily changes the
enable/resume path and adds the debug trace printks which have no influence
on the disable logic. But you said that the machine does not power off in
the bad case. That does not make any sense at all as the enable logic is
not involved at all in the suspend path.

Did you change anything else compared to the tests before ?

Thanks,

	tglx