Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdG1Q7B (ORCPT ); Fri, 28 Jul 2017 12:59:01 -0400 Received: from mga03.intel.com ([134.134.136.65]:4306 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468AbdG1Q67 (ORCPT ); Fri, 28 Jul 2017 12:58:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,425,1496127600"; d="scan'208";a="1200308554" From: Ross Zwisler To: Andrew Morton , linux-kernel@vger.kernel.org Cc: Ross Zwisler , "karam . lee" , Minchan Kim , Jerome Marchand , Nitin Gupta , seungho1.park@lge.com, Matthew Wilcox , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Vishal Verma , linux-nvdimm@lists.01.org Subject: [PATCH 1/3] btt: remove btt_rw_page() Date: Fri, 28 Jul 2017 10:56:02 -0600 Message-Id: <20170728165604.10455-2-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170728165604.10455-1-ross.zwisler@linux.intel.com> References: <20170728165604.10455-1-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 46 The rw_page() interface doesn't provide a clear performance benefit for the BTT and has had a nonzero maintenance burden, so remove it. Signed-off-by: Ross Zwisler Suggested-by: Dan Williams Suggested-by: Christoph Hellwig Cc: Matthew Wilcox --- drivers/nvdimm/btt.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 14323fa..e10d330 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1236,20 +1236,6 @@ static blk_qc_t btt_make_request(struct request_queue *q, struct bio *bio) return BLK_QC_T_NONE; } -static int btt_rw_page(struct block_device *bdev, sector_t sector, - struct page *page, bool is_write) -{ - struct btt *btt = bdev->bd_disk->private_data; - int rc; - - rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector); - if (rc == 0) - page_endio(page, is_write, 0); - - return rc; -} - - static int btt_getgeo(struct block_device *bd, struct hd_geometry *geo) { /* some standard values */ @@ -1261,7 +1247,6 @@ static int btt_getgeo(struct block_device *bd, struct hd_geometry *geo) static const struct block_device_operations btt_fops = { .owner = THIS_MODULE, - .rw_page = btt_rw_page, .getgeo = btt_getgeo, .revalidate_disk = nvdimm_revalidate_disk, }; -- 2.9.4