Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbdG1RCM (ORCPT ); Fri, 28 Jul 2017 13:02:12 -0400 Received: from mga02.intel.com ([134.134.136.20]:24161 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbdG1RCK (ORCPT ); Fri, 28 Jul 2017 13:02:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,425,1496127600"; d="scan'208";a="1200309797" From: Ross Zwisler To: Andrew Morton , linux-kernel@vger.kernel.org Cc: Ross Zwisler , "karam . lee" , Minchan Kim , Jerome Marchand , Nitin Gupta , seungho1.park@lge.com, Matthew Wilcox , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Vishal Verma , linux-nvdimm@lists.01.org Subject: [PATCH 3/3] brd: remove brd_rw_page() Date: Fri, 28 Jul 2017 10:56:04 -0600 Message-Id: <20170728165604.10455-4-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170728165604.10455-1-ross.zwisler@linux.intel.com> References: <20170728165604.10455-1-ross.zwisler@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 41 The rw_page() interface doesn't provide a clear performance benefit for BRD and has had a nonzero maintenance burden, so remove it. Signed-off-by: Ross Zwisler Suggested-by: Dan Williams Suggested-by: Christoph Hellwig Cc: Matthew Wilcox --- drivers/block/brd.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 104b71c..29325058 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -322,15 +322,6 @@ static blk_qc_t brd_make_request(struct request_queue *q, struct bio *bio) return BLK_QC_T_NONE; } -static int brd_rw_page(struct block_device *bdev, sector_t sector, - struct page *page, bool is_write) -{ - struct brd_device *brd = bdev->bd_disk->private_data; - int err = brd_do_bvec(brd, page, PAGE_SIZE, 0, is_write, sector); - page_endio(page, is_write, err); - return err; -} - #ifdef CONFIG_BLK_DEV_RAM_DAX static long __brd_direct_access(struct brd_device *brd, pgoff_t pgoff, long nr_pages, void **kaddr, pfn_t *pfn) @@ -370,7 +361,6 @@ static const struct dax_operations brd_dax_ops = { static const struct block_device_operations brd_fops = { .owner = THIS_MODULE, - .rw_page = brd_rw_page, }; /* -- 2.9.4