Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbdG1RDG (ORCPT ); Fri, 28 Jul 2017 13:03:06 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:38852 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdG1RDD (ORCPT ); Fri, 28 Jul 2017 13:03:03 -0400 Subject: Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register To: Egil Hjelmeland , andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-3-privat@egil-hjelmeland.no> From: Florian Fainelli Message-ID: <37546183-ae5a-b360-0922-dc7e8bc1d79b@gmail.com> Date: Fri, 28 Jul 2017 10:02:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170728151157.28983-3-privat@egil-hjelmeland.no> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 315 Lines: 11 On 07/28/2017 08:11 AM, Egil Hjelmeland wrote: > lan9303_mdio_write()/_read() must multiply register number by 4 to get > offset. > > Added some commments to the register definitions. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Florian Fainelli -- Florian