Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752540AbdG1RPq (ORCPT ); Fri, 28 Jul 2017 13:15:46 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:34613 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbdG1RPp (ORCPT ); Fri, 28 Jul 2017 13:15:45 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170725214756.GA102262@beast> From: Kees Cook Date: Fri, 28 Jul 2017 10:15:43 -0700 X-Google-Sender-Auth: a7CzpenygzkX5f47xwzb3c5Hp3k Message-ID: Subject: Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers To: Alex Deucher Cc: LKML , David Airlie , amd-gfx list , Maling list - DRI developers , Alex Deucher , Rex Zhu , =?UTF-8?Q?Christian_K=C3=B6nig?= , Hawking Zhang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 33 On Thu, Jul 27, 2017 at 6:43 PM, Alex Deucher wrote: > On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: >> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use >> designated initializers") mark other tableFunction entries with designated >> initializers. The randstruct plugin requires designated initializers for >> structures that are entirely function pointers. >> >> Cc: Rex Zhu >> Cc: Hawking Zhang >> Cc: Alex Deucher >> Signed-off-by: Kees Cook >> --- >> If I can get an Ack for this, I'll carry it in the gcc-plugins tree, unless >> you think this is worth landing for v4.13, in which case, please take it >> now. :) >> > > Acked-by: Alex Deucher > > I'm happy to take this through my tree if that is ok with you. Since the randstruct patch depends on this fix, it's likely best to go through my tree unless you can get this into v4.13. (Since then when the randstruct patch lands in v4.14, it'll already be there.) I'm fine either way. Thanks! -Kees -- Kees Cook Pixel Security