Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbdG1Rbq (ORCPT ); Fri, 28 Jul 2017 13:31:46 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57714 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492AbdG1Rbo (ORCPT ); Fri, 28 Jul 2017 13:31:44 -0400 Date: Fri, 28 Jul 2017 10:31:43 -0700 From: Matthew Wilcox To: Ross Zwisler Cc: Andrew Morton , linux-kernel@vger.kernel.org, "karam . lee" , Minchan Kim , Jerome Marchand , Nitin Gupta , seungho1.park@lge.com, Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Vishal Verma , linux-nvdimm@lists.01.org Subject: Re: [PATCH 0/3] remove rw_page() from brd, pmem and btt Message-ID: <20170728173143.GE15980@bombadil.infradead.org> References: <20170728165604.10455-1-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170728165604.10455-1-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 12 On Fri, Jul 28, 2017 at 10:56:01AM -0600, Ross Zwisler wrote: > Dan Williams and Christoph Hellwig have recently expressed doubt about > whether the rw_page() interface made sense for synchronous memory drivers > [1][2]. It's unclear whether this interface has any performance benefit > for these drivers, but as we continue to fix bugs it is clear that it does > have a maintenance burden. This series removes the rw_page() > implementations in brd, pmem and btt to relieve this burden. Why don't you measure whether it has performance benefits? I don't understand why zram would see performance benefits and not other drivers. If it's going to be removed, then the whole interface should be removed, not just have the implementations removed from some drivers.