Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbdG1Rym (ORCPT ); Fri, 28 Jul 2017 13:54:42 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33631 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbdG1Ryj (ORCPT ); Fri, 28 Jul 2017 13:54:39 -0400 Subject: Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode To: Corentin Labbe , Andrew Lunn Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, peppe.cavallaro@st.com, alexandre.torgue@st.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io References: <20170728092818.23419-1-clabbe.montjoie@gmail.com> <20170728135544.GD32230@lunn.ch> <20170728142508.GA7221@Red> <20170728143600.GB2132@lunn.ch> <20170728144424.GB7221@Red> From: Florian Fainelli Message-ID: Date: Fri, 28 Jul 2017 10:54:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170728144424.GB7221@Red> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 43 On 07/28/2017 07:44 AM, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: >>>> I've probably asked this before: Does the internal PHY use a different >>>> PHY ID in registers 2 and 3? >>>> >>> >>> yes >>> >>> reg2: 0x0044 >>> reg3: 0X1500 > > Copy/paste error, its 1400 > >> >> So this is not about loading the correct PHY driver. You can already >> do this based on the PHY IDs... >> >> This is about selecting which PHY to use. Internal or External? >> >> Andrew > > It is too late when we know the PHY ID. > We need to set a syscon for choosing external/internal PHY. > So we can rely only on DT. Since the Device Tree needs to be correct to identify which PHY to use (internal or external), if you use the standard compatible string for the PHY that contains its OUI, e.g: compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22" then you can have your Ethernet MAC identify whether this is an internal PHY by having a list of compatible strings to match against. Corentin, can you make sure you copy netdev, Andrew and myself on the next submissions so we don't have to keep track of seemingly identical threads (this one + the rockchip dwmac changes) and we can work towards one solution? Thanks -- Florian