Message-ID: <1501266340.14866.36.camel@collabora.com>
Subject: Re: [PATCH 0/3] selftests: sync test conversion to TAP13
From: Gustavo Padovan <gustavo.padovan@collabora.com>
To: Shuah Khan <shuahkh@osg.samsung.com>, shuah@kernel.org,
        emilio.lopez@collabora.co.uk, mpe@ellerman.id.au
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 28 Jul 2017 15:25:40 -0300
In-Reply-To: <cover.1500928925.git.shuahkh@osg.samsung.com>
References: <cover.1500928925.git.shuahkh@osg.samsung.com>
Organization: Collabora Ltd
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 36

Hi Shuah,

Thank you for your patches.

On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote:
> This patch series includes patches to convert sync test to use TAP13
> ksft framework. In addition, fix to sync test to differentiate
> between
> unsupported feature and access error when a non-root user runs it.
> 
> Updated kfst framework to return counters for sync test to use to
> print
> the final pass or fail summary message. Updated ksft+print_cnts() to
> print counters to summarize the test results.
> 
> Shuah Khan (3):
>   selftests: sync: differentiate between sync unsupported and access
>     errors
>   selftests: kselftest framework: add API to return pass/fail/*
> counts
>   selftests: sync: convert to use TAP13 ksft framework
> 
>  tools/testing/selftests/kselftest.h      | 10 +++++
>  tools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++-
> ----------
>  tools/testing/selftests/sync/synctest.h  |  3 +-
>  3 files changed, 58 insertions(+), 26 deletions(-)

All looks good to me, so for the 3 patches:
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

	Gustavo

-- 
Gustavo Padovan
Collabora Ltd.