Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbdG1TMw (ORCPT ); Fri, 28 Jul 2017 15:12:52 -0400 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:51298 "EHLO resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbdG1TMu (ORCPT ); Fri, 28 Jul 2017 15:12:50 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 0/3] selftests: sync test conversion to TAP13 To: Gustavo Padovan , Shuah Khan , emilio.lopez@collabora.co.uk, mpe@ellerman.id.au Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan References: <1501266340.14866.36.camel@collabora.com> From: Shuah Khan Message-ID: <6027a4dd-82f8-6886-7fc6-a9c1553c5e34@kernel.org> Date: Fri, 28 Jul 2017 13:12:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1501266340.14866.36.camel@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfNbYbRoblcpcxtMJURKW45NPc1+9QxftUbVH6AmL8fT5U8WzsTmrsJR/NEz6/B/GgcG9b8fIovbHYYY+LSbvyna1djIR9yuHyuR8fQXh9N/avBegxiAg nuZSgQgFt17qL+KL81wZ0GXIm5yUHbkGHDSa8MhB/bmz2I2IrjTWemJUhLIgZRdqD8/x0vJ+4P199BVBai6ZArysV0PnMfLeqtZd2sAAn8DZ5wothzuvEg8l 5/ly5UTSvIfHXWYpQcYK8q41DOryrOKGf9H6w6Jo4tHBCaUBZoFjll1ZYA+9Rt8pTpWU1NTGDJrHvCQFupdV5T9fyj9+sJ52A1jc1dM2/R+cm7dP811rBVhe TrZSZLLwapkfmnwtrEAvcj5SoG7DuPA62ynFPuS5A+9nJS6ppH4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 39 On 07/28/2017 12:25 PM, Gustavo Padovan wrote: > Hi Shuah, > > Thank you for your patches. > > On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote: >> This patch series includes patches to convert sync test to use TAP13 >> ksft framework. In addition, fix to sync test to differentiate >> between >> unsupported feature and access error when a non-root user runs it. >> >> Updated kfst framework to return counters for sync test to use to >> print >> the final pass or fail summary message. Updated ksft+print_cnts() to >> print counters to summarize the test results. >> >> Shuah Khan (3): >> selftests: sync: differentiate between sync unsupported and access >> errors >> selftests: kselftest framework: add API to return pass/fail/* >> counts >> selftests: sync: convert to use TAP13 ksft framework >> >> tools/testing/selftests/kselftest.h | 10 +++++ >> tools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++- >> ---------- >> tools/testing/selftests/sync/synctest.h | 3 +- >> 3 files changed, 58 insertions(+), 26 deletions(-) > > All looks good to me, so for the 3 patches: > Reviewed-by: Gustavo Padovan > > Gustavo > Thanks Gustavo. I will get them in to linux-ksefltest next for 4.14-rc1 with your Reviwed-by. -- Shuah