Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265692AbTFXE52 (ORCPT ); Tue, 24 Jun 2003 00:57:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265693AbTFXE52 (ORCPT ); Tue, 24 Jun 2003 00:57:28 -0400 Received: from dp.samba.org ([66.70.73.150]:38315 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id S265692AbTFXE51 (ORCPT ); Tue, 24 Jun 2003 00:57:27 -0400 From: Rusty Russell To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk Subject: Re: [PATCH] proper allocation of hwif->io_ports resources In-reply-to: Your message of "Mon, 23 Jun 2003 23:45:43 +0200." <200306232345.43959.bzolnier@elka.pw.edu.pl> Date: Tue, 24 Jun 2003 14:14:56 +1000 Message-Id: <20030624051135.B2A1A2C01B@lists.samba.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 18 In message <200306232345.43959.bzolnier@elka.pw.edu.pl> you write: > +int ide_hwif_request_regions (ide_hwif_t *hwif) .... > +void ide_hwif_release_regions (ide_hwif_t *hwif) .... A little too much whitespace. Other than that, looks fine at a brief glance. Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/