Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753293AbdG1XwU convert rfc822-to-8bit (ORCPT ); Fri, 28 Jul 2017 19:52:20 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:32409 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbdG1XwS (ORCPT ); Fri, 28 Jul 2017 19:52:18 -0400 From: Salil Mehta To: Andrew Lunn CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Thread-Topic: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Thread-Index: AQHTB/DFF2KBu87m90Sc3N4NhPX+9qJpwSqAgAAn5MA= Date: Fri, 28 Jul 2017 23:52:07 +0000 Message-ID: References: <20170728222652.118448-1-salil.mehta@huawei.com> <20170728222652.118448-7-salil.mehta@huawei.com> <20170728232859.GB16080@lunn.ch> In-Reply-To: <20170728232859.GB16080@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.161] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.597BCE2F.0029,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.170, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3d18812e9a6ba4b9c6bf9636f8a7dc0a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 40 Hi Andrew, > -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Andrew Lunn > Sent: Saturday, July 29, 2017 12:29 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 6/8] net: hns3: Add MDIO support to > HNS3 Ethernet driver for hip08 SoC > > > +int hclge_mac_mdio_config(struct hclge_dev *hdev) > > +{ > .. > > > +} > > + > > +int hclge_mac_start_phy(struct hclge_dev *hdev) > > +{ > > > +} > > + > > +void hclge_mac_stop_phy(struct hclge_dev *hdev) > > +{ > > +} > > -- > > These are not static functions. So i would expect them to be in a > header file somewhere.... Sure. > > Andrew > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html