Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbdG1Xzs (ORCPT ); Fri, 28 Jul 2017 19:55:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59830 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbdG1Xzr (ORCPT ); Fri, 28 Jul 2017 19:55:47 -0400 Date: Fri, 28 Jul 2017 16:55:35 -0700 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Marcus Wolf , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: fix Kconfig entry Message-ID: <20170728235535.GA5432@kroah.com> References: <20170725153825.272975-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170725153825.272975-1-arnd@arndb.de> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 23 On Tue, Jul 25, 2017 at 05:38:05PM +0200, Arnd Bergmann wrote: > I ran into a build error with the new pi433 driver and > CONFIG_SPI disabled: > > drivers/staging/pi433/pi433_if.o: In function `pi433_probe.part.6': > pi433_if.c:(.text+0x1657): undefined reference to `spi_write_then_read' > drivers/staging/pi433/pi433_if.o: In function `pi433_probe': > pi433_if.c:(.text+0x1d28): undefined reference to `spi_setup' > drivers/staging/pi433/pi433_if.o: In function `pi433_init': > > I'm adding a Kconfig dependency on CONFIG_SPI here to avoid that, > and since I spot two cosmetic mistakes in the entry, I'm also > fixing the whitespace and remove the redundant 'default n'. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Arnd Bergmann Randy sent in a patch just like this before you did, but he didn't touch the space/tab issue. thanks, greg k-h