Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbdG1X5Y convert rfc822-to-8bit (ORCPT ); Fri, 28 Jul 2017 19:57:24 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:32410 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbdG1X5W (ORCPT ); Fri, 28 Jul 2017 19:57:22 -0400 From: Salil Mehta To: Andrew Lunn CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Thread-Topic: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Thread-Index: AQHTB/DFa9Av/6Am30SlCwI7ZycJ9qJpxtwAgAAihUA= Date: Fri, 28 Jul 2017 23:57:11 +0000 Message-ID: References: <20170728222652.118448-1-salil.mehta@huawei.com> <20170728222652.118448-8-salil.mehta@huawei.com> <20170728234922.GC16080@lunn.ch> In-Reply-To: <20170728234922.GC16080@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.161] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.597BCF5F.006E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.170, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 42048d0be342f310da16fd4c37561b0b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2282 Lines: 68 Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Saturday, July 29, 2017 12:49 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > On Fri, Jul 28, 2017 at 11:26:51PM +0100, Salil Mehta wrote: > > +static const struct hns3_link_mode_mapping hns3_lm_map[] = { > > + {HNS3_LM_FIBRE_BIT, ETHTOOL_LINK_MODE_FIBRE_BIT, FLG}, > > + {HNS3_LM_AUTONEG_BIT, ETHTOOL_LINK_MODE_Autoneg_BIT, FLG}, > > + {HNS3_LM_TP_BIT, ETHTOOL_LINK_MODE_TP_BIT, FLG}, > > + {HNS3_LM_PAUSE_BIT, ETHTOOL_LINK_MODE_Pause_BIT, FLG}, > > + {HNS3_LM_BACKPLANE_BIT, ETHTOOL_LINK_MODE_Backplane_BIT, FLG}, > > + {HNS3_LM_10BASET_HALF_BIT, ETHTOOL_LINK_MODE_10baseT_Half_BIT, > FLG}, > > + {HNS3_LM_10BASET_FULL_BIT, ETHTOOL_LINK_MODE_10baseT_Full_BIT, > FLG}, > > + {HNS3_LM_100BASET_HALF_BIT, ETHTOOL_LINK_MODE_100baseT_Half_BIT, > FLG}, > > + {HNS3_LM_100BASET_FULL_BIT, ETHTOOL_LINK_MODE_100baseT_Full_BIT, > FLG}, > > + {HNS3_LM_1000BASET_FULL_BIT, > ETHTOOL_LINK_MODE_1000baseT_Full_BIT, FLG}, > > +}; > > It seems like all entries have link_mode_ksettings set to FLG. Which > probably indicates it is pointless. It is to support SUPPORTED and ADVERTISED link modes. > > > + > > +static inline void hns3_driv_to_eth_caps(u32 caps, > > + struct ethtool_link_ksettings *cmd) > > Please don't use inline anywhere except in header file stub > functions. Let the compiler decide. This was added as per Florian's comment. > > > +static int hns3_get_link_ksettings(struct net_device *netdev, > > + struct ethtool_link_ksettings *cmd) > > +{ > > + struct hns3_nic_priv *priv = netdev_priv(netdev); > > + struct hnae3_handle *h = priv->ae_handle; > > + u32 supported_caps; > > + u32 advertised_caps; > > + u8 media_type; > > + u8 link_stat; > > + u8 auto_neg; > > + u8 duplex; > > + u32 speed; > > + > > + if (!h->ae_algo || !h->ae_algo->ops) > > + return -ESRCH; > > #define ESRCH 3 /* No such process */ > > No such process ???? Seems weird return error. Will correct this. Thanks! > > Andrew