Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753127AbdG2A6Q (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Jul 2017 20:58:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38378 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752848AbdG2A6P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Jul 2017 20:58:15 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6504A5004E
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com
Date: Fri, 28 Jul 2017 19:58:13 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Chris J Arges <chris.j.arges@canonical.com>,
        Borislav Petkov <bp@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        Michael Davidson <md@google.com>, Greg Hackmann <ghackmann@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Stephen Hines <srhines@google.com>, Kees Cook <keescook@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Bernhard =?utf-8?Q?Rosenkr=C3=A4nzer?= 
        <Bernhard.Rosenkranzer@linaro.org>
Subject: Re: [PATCH] Revert "x86/uaccess: Add stack frame output operand in
 get_user() inline asm"
Message-ID: <20170729005813.yctucsc5uzpa2ukc@treble>
References: <20170713211245.GG95735@google.com>
 <20170713213406.gx4ixkx6kxa4ppps@treble>
 <20170713215704.GJ95735@google.com>
 <20170719174630.kz5g553evcrnirmr@treble>
 <CAPAsAGyyzLC24cj=-EUE4WGPQ_UQTCJNvWKVUKxPQmJmAtU3HA@mail.gmail.com>
 <20170720151813.5wnpsb5wy7bqrpec@treble>
 <CAPAsAGwHLgZtyy4-rvaJiYczV7+3d8sygDyUDM__05GXHGj2QA@mail.gmail.com>
 <20170720205652.patvjnfqymrv73ho@treble>
 <20170729003852.GD84665@google.com>
 <20170729005521.2lhekao5fvb452oy@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170729005521.2lhekao5fvb452oy@treble>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 29 Jul 2017 00:58:15 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 266
Lines: 8

On Fri, Jul 28, 2017 at 07:55:21PM -0500, Josh Poimboeuf wrote:
> +#define ASM_CALL(str, outputs, inputs, clobbers...) \
> +	asm volatile(str : outputs : inputs : "sp", ## clobbers)

And note this part isn't right, the sp should be in the output operands.

-- 
Josh