Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753242AbdG2Bvb (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Jul 2017 21:51:31 -0400
Received: from mail-wr0-f196.google.com ([209.85.128.196]:37278 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753159AbdG2Bva (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Jul 2017 21:51:30 -0400
MIME-Version: 1.0
In-Reply-To: <20170727223817.7494-1-f.fainelli@gmail.com>
References: <20170727223817.7494-1-f.fainelli@gmail.com>
From: Gregory Fong <gregory.0xf0@gmail.com>
Date: Fri, 28 Jul 2017 18:50:58 -0700
Message-ID: <CADtm3G4Rnm1276qYWe_MSnoZ2_Lxc1QFCUx1ZVfWtb5n4M2T2w@mail.gmail.com>
Subject: Re: [PATCH] irqchip: brcmstb-l2: Define an irq_pm_shutdown function
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Doug Berger <opendmb@gmail.com>, Kevin Cernekee <cernekee@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Brian Norris <computersforpeace@gmail.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@broadcom.com>,
        "open list:BROADCOM BMIPS MIPS ARCHITECTURE" 
        <linux-mips@linux-mips.org>,
        "open list:IRQCHIP DRIVERS" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 636
Lines: 11

On Thu, Jul 27, 2017 at 3:38 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> The Broadcom STB platforms support S5 and we allow specific hardware
> wake-up events to take us out of this state. Because we were not
> defining an irq_pm_shutdown() function pointer, we would not be
> correctly masking non-wakeup events, which would result in spurious
> wake-ups from sources that were not explicitly configured for wake-up.
>
> Fixes: 7f646e92766e ("irqchip: brcmstb-l2: Add Broadcom Set Top Box Level-2 interrupt controller")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Acked-by: Gregory Fong <gregory.0xf0@gmail.com>