Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbdG2IvW (ORCPT ); Sat, 29 Jul 2017 04:51:22 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:38360 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbdG2IvT (ORCPT ); Sat, 29 Jul 2017 04:51:19 -0400 Date: Sat, 29 Jul 2017 10:51:15 +0200 (CEST) From: Marcus Wolf To: Greg KH Cc: "kbuild-all@01.org" , Dan Carpenter , "linux-kernel@vger.kernel.org" , Rob Herring , driverdevel , Geert Uytterhoeven , "devicetree@vger.kernel.org" , Grant Likely Message-ID: <1812078351.11080.1501318275697@ox.hosteurope.de> In-Reply-To: <20170729000118.GA28861@kroah.com> References: <39f4e59cae6d241235f8f2cc6eebb33c-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheVn4GUFc=-webmailer1@server05.webmailer.hosteurope.de> <201707172156.DCyTyWc2%fengguang.wu@intel.com> <652336354.3806.1500549785404@ox.hosteurope.de> <20170720113705.d65hxm3jbki2ynqd@mwanda> <255867683.7064.1500566196444@ox.hosteurope.de> <20170729000118.GA28861@kroah.com> Subject: Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev29 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1501318279;eacc1209; X-HE-SMSGID: 1dbNSt-0006rV-Ps Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 40 Hi Greg, already had a discussion concerning that patch with Dan yesterday. I really don't know what's going on there. I detached the patch once more from my outbox and had a very close look in an editor and looked at it with a difftool. In my outbox the patch is fine. I really don't knwo why it reaches you crapped. Since there are contsant problems with my patches, I will stop sending patches for a while. As soon as I can find time to deeply confess with the tooling, I will start over with trying. Concerning this patch: You can use Arnds Patch from yesterday instead: [PATCH] staging: pi433: use div_u64 for 64-bit division It's a bit different to my patch, but according to yesterdays discussion, it should also fix the problem. Sorry for any inconvenience, Marcus > Greg KH hat am 29. Juli 2017 um 02:01 > geschrieben: > > > On Thu, Jul 20, 2017 at 05:56:36PM +0200, Marcus Wolf wrote: > > Fixes problem with division in rf69_set_deviation > > > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > > Signed-off-by: Marcus Wolf > > > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > > --- a/drivers/staging/pi433/rf69.c > > +++ b/drivers/staging/pi433/rf69.c > > @@ -221,7 +221,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 > > frequency) > > Patch is line-wrapped and does not apply :( >