Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbdG2VJ6 (ORCPT ); Sat, 29 Jul 2017 17:09:58 -0400 Received: from gloria.sntech.de ([95.129.55.99]:36208 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdG2VJ4 (ORCPT ); Sat, 29 Jul 2017 17:09:56 -0400 From: Heiko Stuebner To: Sugar Zhang Cc: broonie@kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Liang Chen , Shawn Lin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] arm64: dts: rockchip: add rk3328 i2s nodes Date: Sat, 29 Jul 2017 23:09:41 +0200 Message-ID: <12755546.8f2g0BVaYa@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1501143365-76104-2-git-send-email-sugar.zhang@rock-chips.com> References: <1501143365-76104-1-git-send-email-sugar.zhang@rock-chips.com> <1501143365-76104-2-git-send-email-sugar.zhang@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 27 Am Donnerstag, 27. Juli 2017, 16:16:03 CEST schrieb Sugar Zhang: > This patch add the i2s dt nodes for rk3328. > > Signed-off-by: Sugar Zhang > --- > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 33 ++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index 0be96ce..f1a284b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -156,6 +156,39 @@ > clock-output-names = "xin24m"; > }; > > + i2s0: i2s@ff000000 { > + compatible = "rockchip,rk3328-i2s", "rockchip,rk3066-i2s"; It looks like the rockchip,rk3328-i2s compatible is missing in the binding documentation (Documentation/devicetree/bindings/sound/rockchip-i2s.txt) Send a patch adding it first please. Heiko