Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbdG2VSQ (ORCPT ); Sat, 29 Jul 2017 17:18:16 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42042 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbdG2VSP (ORCPT ); Sat, 29 Jul 2017 17:18:15 -0400 Date: Sat, 29 Jul 2017 14:18:13 -0700 (PDT) Message-Id: <20170729.141813.2129692875257358096.davem@davemloft.net> To: sunil.kovvuri@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sgoutham@cavium.com Subject: Re: [PATCH] net: thunderx: Fix BGX transmit stall due to underflow From: David Miller In-Reply-To: <1501140184-25625-1-git-send-email-sunil.kovvuri@gmail.com> References: <1501140184-25625-1-git-send-email-sunil.kovvuri@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 29 Jul 2017 14:18:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 17 From: sunil.kovvuri@gmail.com Date: Thu, 27 Jul 2017 12:53:04 +0530 > From: Sunil Goutham > > For SGMII/RGMII/QSGMII interfaces when physical link goes down > while traffic is high is resulting in underflow condition being set > on that specific BGX's LMAC. Which assets a backpresure and VNIC stops > transmitting packets. > > This is due to BGX being disabled in link status change callback while > packet is in transit. This patch fixes this issue by not disabling BGX > but instead just disables packet Rx and Tx. > > Signed-off-by: Sunil Goutham Applied.