Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbdG3NEy (ORCPT ); Sun, 30 Jul 2017 09:04:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33028 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbdG3NEw (ORCPT ); Sun, 30 Jul 2017 09:04:52 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 30 Jul 2017 18:34:51 +0530 From: Abhishek Sahu To: Stephen Boyd Cc: mturquette@baylibre.com, andy.gross@linaro.org, david.brown@linaro.org, rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 02/12] clk: qcom: flag for 64 bit CONFIG_CTL In-Reply-To: <20170728183321.GG2146@codeaurora.org> References: <1501153825-5181-1-git-send-email-absahu@codeaurora.org> <1501153825-5181-3-git-send-email-absahu@codeaurora.org> <20170728183321.GG2146@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 41 On 2017-07-29 00:03, Stephen Boyd wrote: > On 07/27, Abhishek Sahu wrote: >> diff --git a/drivers/clk/qcom/clk-alpha-pll.c >> b/drivers/clk/qcom/clk-alpha-pll.c >> index 47a1da3..e6cde2d 100644 >> --- a/drivers/clk/qcom/clk-alpha-pll.c >> +++ b/drivers/clk/qcom/clk-alpha-pll.c >> @@ -118,7 +118,10 @@ void clk_alpha_pll_configure(struct clk_alpha_pll >> *pll, struct regmap *regmap, >> regmap_write(regmap, off + PLL_L_VAL, config->l); >> regmap_write(regmap, off + PLL_ALPHA_VAL, config->alpha); >> regmap_write(regmap, off + PLL_CONFIG_CTL, config->config_ctl_val); >> - regmap_write(regmap, off + PLL_CONFIG_CTL_U, >> config->config_ctl_hi_val); >> + >> + if (pll->flags & SUPPORTS_64BIT_CONFIG_CTL) >> + regmap_write(regmap, off + PLL_CONFIG_CTL_U, >> + config->config_ctl_hi_val); > > Is there a hole there? I mean a RAZ/WI register so we can just > keep writing it and not care? We don't have hole for most of the alpha PLL. The offset for CONFIG_CTL itself is not same for all types of Alpha PLL and the same is being handled in patch 4 of this patch series. Spark PLL CONFIG_CTL 0x18 TEST_CTL 0x1C TEST_CTL_U 0x20 Brammo PLL CONFIG_CTL 0x18 TEST_CTL 0x1C PLL_STATUS 0x24 Hyuara PLL CONFIG_CTL 0x14 CONFIG_CTL_U 0x18 TEST_CTL 0x1c