Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184AbdG3PVu (ORCPT ); Sun, 30 Jul 2017 11:21:50 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:33716 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdG3PVt (ORCPT ); Sun, 30 Jul 2017 11:21:49 -0400 Date: Sun, 30 Jul 2017 17:21:44 +0200 (CEST) From: Marcus Wolf To: Greg KH , Dan Carpenter Cc: "kbuild-all@01.org" , "linux-kernel@vger.kernel.org" , driverdevel , "devicetree@vger.kernel.org" Message-ID: <1603596658.13802.1501428104756@ox.hosteurope.de> In-Reply-To: <20170729222127.GB16460@kroah.com> References: <39f4e59cae6d241235f8f2cc6eebb33c-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheVn4GUFc=-webmailer1@server05.webmailer.hosteurope.de> <201707172156.DCyTyWc2%fengguang.wu@intel.com> <652336354.3806.1500549785404@ox.hosteurope.de> <20170720113705.d65hxm3jbki2ynqd@mwanda> <255867683.7064.1500566196444@ox.hosteurope.de> <20170729000118.GA28861@kroah.com> <1812078351.11080.1501318275697@ox.hosteurope.de> <20170729222127.GB16460@kroah.com> Subject: Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev29 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1501428108;4b0960be; X-HE-SMSGID: 1dbq2K-0005Ov-S7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2031 Lines: 59 Hi Greg, hi Dan the toolingproblem is a little bit more complicated. Since a mainline kernel isn't directly able to boot on the RasPi, for testing I work with a Raspbian kernel. Since at the beginning, I never thought of submitting the driver, I started with a side-build project with SVN - that's stil my master... In addition, disk is full :-( So in principle nothing is really adequate to meet the need of easy participating in kernel development. I will revise my tooling, as soon as I find the time and quietness - most probably I need to setup from scratch. For the announced change in rf69.c I will try to equip an SVN-diff with apropriate headers next week, so Dan can crosscheck with his work - I hope, I will make it without errors... Have a nice weekend, Marcus > Greg KH hat am 30. Juli 2017 um 00:21 > geschrieben: > > > On Sat, Jul 29, 2017 at 10:51:15AM +0200, Marcus Wolf wrote: > > Hi Greg, > > > > already had a discussion concerning that patch with Dan yesterday. > > I really don't know what's going on there. I detached the patch once more > > from > > my outbox and had a very close look in an editor and looked at it with a > > difftool. In my outbox the patch is fine. I really don't knwo why it reaches > > you > > crapped. > > > > Since there are contsant problems with my patches, I will stop sending > > patches > > for a while. As soon as I can find time to deeply confess with the tooling, > > I > > will start over with trying. > > Just use 'git send-email' for patches if you are having problems with > your email client. And get a better email client the kernel > Documentation has a whole file just about that topic and how to do it > correctly. > > > Concerning this patch: You can use Arnds Patch from yesterday instead: > > [PATCH] staging: pi433: use div_u64 for 64-bit division > > It's a bit different to my patch, but according to yesterdays discussion, it > > should also fix the problem. > > I already took it into my tree. > > thanks, > > greg k-h >