Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754419AbdG3SLC (ORCPT ); Sun, 30 Jul 2017 14:11:02 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:35246 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754210AbdG3SLA (ORCPT ); Sun, 30 Jul 2017 14:11:00 -0400 MIME-Version: 1.0 In-Reply-To: <1501355870-13960-2-git-send-email-david@lechnology.com> References: <1501355870-13960-1-git-send-email-david@lechnology.com> <1501355870-13960-2-git-send-email-david@lechnology.com> From: Andy Shevchenko Date: Sun, 30 Jul 2017 21:10:59 +0300 Message-ID: Subject: Re: [PATCH 1/6] drm/tinydrm: Add parameter for MIPI DCS pixel format To: David Lechner Cc: dri-devel@lists.freedesktop.org, devicetree , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , David Airlie , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , linux-fbdev@vger.kernel.org, linux-arm Mailing List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 27 On Sat, Jul 29, 2017 at 10:17 PM, David Lechner wrote: > This adds a parameter for MIPI DCS pixel format to mipi_dbi_init(). > This is in preparation for supporting displays that don't use a 16bpp > memory layout. > /* MIPI DCS pixel formats */ > -#define MIPI_DCS_PIXEL_FMT_24BIT 7 > -#define MIPI_DCS_PIXEL_FMT_18BIT 6 > -#define MIPI_DCS_PIXEL_FMT_16BIT 5 > -#define MIPI_DCS_PIXEL_FMT_12BIT 3 > -#define MIPI_DCS_PIXEL_FMT_8BIT 2 > -#define MIPI_DCS_PIXEL_FMT_3BIT 1 > +enum mipi_dcs_pixel_format { > + MIPI_DCS_PIXEL_FMT_24BIT = 7, > + MIPI_DCS_PIXEL_FMT_18BIT = 6, > + MIPI_DCS_PIXEL_FMT_16BIT = 5, > + MIPI_DCS_PIXEL_FMT_12BIT = 3, > + MIPI_DCS_PIXEL_FMT_8BIT = 2, > + MIPI_DCS_PIXEL_FMT_3BIT = 1, > +}; May I ask what prevents us to arrange enums in natural ordering (you may keep = X parts, of course)? -- With Best Regards, Andy Shevchenko