Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418AbdG3SYH (ORCPT ); Sun, 30 Jul 2017 14:24:07 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34494 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754228AbdG3SYE (ORCPT ); Sun, 30 Jul 2017 14:24:04 -0400 MIME-Version: 1.0 In-Reply-To: <1501355870-13960-5-git-send-email-david@lechnology.com> References: <1501355870-13960-1-git-send-email-david@lechnology.com> <1501355870-13960-5-git-send-email-david@lechnology.com> From: Andy Shevchenko Date: Sun, 30 Jul 2017 21:24:03 +0300 Message-ID: Subject: Re: [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id To: David Lechner Cc: dri-devel@lists.freedesktop.org, devicetree , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , David Airlie , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , linux-fbdev@vger.kernel.org, linux-arm Mailing List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 499 Lines: 15 On Sat, Jul 29, 2017 at 10:17 PM, David Lechner wrote: > This refactors the mipi-panel module to use the driver id for panel-specific > data. This is in preparation for adding additional panels. > Wouldn't be better to split glue driver from what looks like more generic in the first place? Then you will not need to spread some stuff over generic files. Are we going to disrupt genericy of the framework already with second driver?! -- With Best Regards, Andy Shevchenko