Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751199AbdGaEZ5 (ORCPT ); Mon, 31 Jul 2017 00:25:57 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:38345 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdGaEZ4 (ORCPT ); Mon, 31 Jul 2017 00:25:56 -0400 Date: Mon, 31 Jul 2017 09:55:52 +0530 From: Viresh Kumar To: Julia Lawall Cc: Johan Hovold , devel@driverdev.osuosl.org, Alex Elder , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [greybus-dev] [PATCH 10/11] greybus: usb: constify hc_driver structures Message-ID: <20170731042552.GC5804@vireshk-i7> References: <1501274518-25170-1-git-send-email-Julia.Lawall@lip6.fr> <1501274518-25170-11-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501274518-25170-11-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 31 On 28-07-17, 22:41, Julia Lawall wrote: > The hc_driver structure is only passed as the first argument to > usb_create_hcd, which is declared as const. Thus the hc_driver structure > itself can be const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/staging/greybus/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c > index ccadda0..f93a76d 100644 > --- a/drivers/staging/greybus/usb.c > +++ b/drivers/staging/greybus/usb.c > @@ -139,7 +139,7 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex, > return ret; > } > > -static struct hc_driver usb_gb_hc_driver = { > +static const struct hc_driver usb_gb_hc_driver = { > .description = "greybus-hcd", > .product_desc = "Greybus USB Host Controller", > .hcd_priv_size = sizeof(struct gb_usb_device), Reviewed-by: Viresh Kumar -- viresh