Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750986AbdGaGdG (ORCPT ); Mon, 31 Jul 2017 02:33:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21896 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdGaGdF (ORCPT ); Mon, 31 Jul 2017 02:33:05 -0400 Subject: Re: [PATCH v2 2/2] userfaultfd: selftest: Add tests for UFFD_FEATURE_SIGBUS feature To: Mike Rapoport References: <1501208320-200277-1-git-send-email-prakash.sangappa@oracle.com> <20170730070749.GB22926@rapoport-lnx> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, aarcange@redhat.com, akpm@linux-foundation.org, mike.kravetz@oracle.com From: Prakash Sangappa Message-ID: Date: Sun, 30 Jul 2017 23:32:53 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170730070749.GB22926@rapoport-lnx> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 37 On 7/30/17 12:07 AM, Mike Rapoport wrote: > On Thu, Jul 27, 2017 at 10:18:40PM -0400, Prakash Sangappa wrote: >> This patch adds tests for UFFD_FEATURE_SIGBUS feature. The >> tests will verify signal delivery instead of userfault events. >> Also, test use of UFFDIO_COPY to allocate memory and retry >> accessing monitored area after signal delivery. >> >> This patch also fixes a bug in uffd_poll_thread() where 'uffd' >> is leaked. >> >> Signed-off-by: Prakash Sangappa >> --- >> Change log >> >> v2: >> - Added comments to explain the tests. >> - Fixed test to fail immediately if signal repeats. >> - Addressed other review comments. >> >> v1: https://lkml.org/lkml/2017/7/26/101 >> --- > Overall looks good to me, just small nitpick below. [...] >> for (nr = 0; nr < split_nr_pages; nr++) { >> + if (signal_test) { >> + if (sigsetjmp(*sigbuf, 1) != 0) { >> + if (nr == lastnr) { >> + sig_repeats++; > You can simply 'return 1' here, then sig_repeats variable can be dropped > and the return statement for signal_test can be simplified. Ok, sent v3 patch with this change. Thanks, -Prakash.